Hi,
After downloading Metronic ASP.NET Core 8.2.5 and following the instructions from Getting Started doc using yarn install
and gulp --demo1
when running the project, it runs just fine and visually looks correct, but in the console, there is following error:
Uncaught ReferenceError: Tagify is not defined
at initForm (new-target.js:15:14)
at Object.init (new-target.js:202:4)
at HTMLDocument.<anonymous> (new-target.js:210:19)
Hi,
Sorry for the late reply.
We have reproduced the error you mentioned and are currently working on a solution. The fix will be included in the next Metronic release.
I will get back to you with instructions once the fix is ready. Thanks for your patience!
Regards,
Lauris Stepanovs,
Keenthemes Support Team
Hi Lauris,
Thanks for the reply.
To make your life easier , the problem is on line # 194 of
gulp.config.js
file where Tagify is referenced. Basically it is referencing tagify.min.js
, but in the dist folder when it is downloaded, the min file does not exist, so it should be tagify.js
instead. Here is the updated line that will work:
{$config.path.node_modules}/@yaireo/tagify/dist/tagify.js",
Hi,
Thank you for your feedback.
We will apply this fix and include it in the next Metronic release.
Regards,
Lauris Stepanovs,
Keenthemes Support Team
Lauris,
BTW do you have any channel where we can submit suggestions in regard to ASP.NET Core build you provide? Specifically, related to how folders are structured to make it easier for us to apply updates when you release them.
Thanks
Hi,
You can leave your suggestions here I will create a task in our backlog and we will consider implementing it in upcoming Metronic releases.
Regards,
Lauris Stepanovs,
Keenthemes Support Team
Hi Lauris,
Here are my suggestions:
FIRST SUGGESTION
Currently in the folder structure Starterkit\_keenthemes
contains two folders src
and tools
. These folders contain source files for node modules and Javascript & CSS that then being compiled into wwwroot
if I understand correctly.
I will suggest moving these folders to the root, same level with StarterKit
folder, as these files are not related to ASP.NET project at all and are unnecessary.
So basically you will have:build\src
build\tools
Starterkit\_keenthemes\config
Starterkit\_keenthemes\libs
Let me know if you have any questions in regard to the above. From what I understand only 2 lines will need to be change one in gulp.config.js
and one in webpack.config.js
.
SECOND SUGGESTION
It will be good, if Starterkit\Views
will contain CSHTML files of only the demo that was used when calling gulp --demo1
rather than both Demo1
and Demo30
files. Regardless other one is not going to work as JS and CSS files will be compiled only for one of these, so it is unnecessary to have these files at all. Same applies to not having extra nested folder as well, so instead of, for example, Starterkit\Views\Pages\Auth\Demo1\NewPassword.cshtml
it will be Starterkit\Views\Pages\Auth\NewPassword.cshtml
, this way it will be cleaner.
THIRD SUGGESTIONS
It will be really good if you can make KTTheme
a NuGet package.
Hopefully this was descriptive enough to make it happen in next version.
There are more suggestions, but these are more complicated and related on how the project is structured and maybe I will write it in another reply.
Thanks
Hayk
Hi Hayk,
Thank you very much for your suggestions.