Get 2024 Templates Mega Bundle!14 Bootstrap, Vue & React Templates + 3 Vector Sets
Get for 99$
Layout service should be revisited in the angular demo1 project
Not sure how did this happen but:
getProp(path: string, config?: ILayout): string | boolean | undefined | Object {
if (config) {
return objectPath.get(config, path);
}
return objectPath.get(this.layoutConfigSubject.value, path);
}This makes the code unsafe. Usages like this:
this.appSidebarDefaultMinimizeMobileEnabled = this.layout.getProp(
"app.sidebar.default.minimize.mobile.enabled",
config
) as boolean;Should be formalized to:
this.appSidebarDefaultMinimizeMobileEnabled = config.app.sidebar.default.minimize.mobile.enabled;Which is typesafe and would immediatley indicate that properties are missing from the LayoutConfiguration.
Replies (1)
Hi Bálint Nagy
Sorry for the delay in response.
Thank you for your suggestion. It's a great idea to enhance the safety of our variables based on the interface. We will consider implementing this in our future updates.
